Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV: Use relative imports #875

Merged
merged 2 commits into from
May 14, 2022
Merged

DEV: Use relative imports #875

merged 2 commits into from
May 14, 2022

Conversation

MartinThoma
Copy link
Member

This is important for some PyPDF2 developers development workflows.
It allows them to compare changes more easily.

See #865 (comment)

This is important for some PyPDF2 developers development workflows.
It allows them to compare changes more easily.

See #865 (comment)
@MartinThoma MartinThoma mentioned this pull request May 13, 2022
@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #875 (d303ba8) into 2.0.0-dev (2478309) will decrease coverage by 0.03%.
The diff coverage is 99.07%.

@@              Coverage Diff              @@
##           2.0.0-dev     #875      +/-   ##
=============================================
- Coverage      82.70%   82.66%   -0.04%     
=============================================
  Files             16       16              
  Lines           3740     3732       -8     
  Branches         793      793              
=============================================
- Hits            3093     3085       -8     
  Misses           472      472              
  Partials         175      175              
Impacted Files Coverage Δ
PyPDF2/_reader.py 81.93% <96.15%> (-0.03%) ⬇️
PyPDF2/__init__.py 100.00% <100.00%> (ø)
PyPDF2/_merger.py 67.90% <100.00%> (ø)
PyPDF2/_page.py 83.27% <100.00%> (-0.07%) ⬇️
PyPDF2/_security.py 93.33% <100.00%> (-0.11%) ⬇️
PyPDF2/_writer.py 88.25% <100.00%> (ø)
PyPDF2/filters.py 75.00% <100.00%> (-0.25%) ⬇️
PyPDF2/generic.py 86.19% <100.00%> (-0.02%) ⬇️
PyPDF2/pagerange.py 100.00% <100.00%> (ø)
PyPDF2/types.py 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2478309...d303ba8. Read the comment docs.

@pubpub-zz
Copy link
Collaborator

I've created a complentary PR #877

DEV : Complement relative imports

some imports missed
also some local imports moved up
@MartinThoma MartinThoma merged commit 4429066 into 2.0.0-dev May 14, 2022
@MartinThoma MartinThoma deleted the relative-imports branch May 14, 2022 13:24
MartinThoma added a commit that referenced this pull request Jun 1, 2022
The 2.0.0 release of PyPDF2 includes three core changes:

1. Dropping support for Python 3.5 and older.
2. Introducing type annotations.
3. Interface changes, mostly to have PEP8-compliant names

We introduced a [deprecation process](#930)
that hopefully helps users to avoid unexpected breaking changes.

Breaking Changes(DEP):
- PyPDF2 2.0 requires Python 3.6+. Python 2.7 and 3.5 support were dropped.
- PdfFileReader: The "warndest" parameter was removed
- PdfFileReader and PdfFileMerger no longer have the `overwriteWarnings`
  parameter. The new behavior is `overwriteWarnings=False`.
- merger: OutlinesObject was removed without replacement.
- merger.py ➔ _merger.py: You must import PdfFileMerger from PyPDF2 directly.
- utils:
  * `ConvertFunctionsToVirtualList` was removed
  * `formatWarning` was removed
  * `isInt(obj)`: Use `instance(obj, int)` instead
  * `u_(s)`: Use `s` directly
  * `chr_(c)`: Use `chr(c)` instead
  * `barray(b)`: Use `bytearray(b)` instead
  * `isBytes(b)`: Use `instance(b, type(bytes()))` instead
  * `xrange_fn`: Use `range` instead
  * `string_type`: Use `str` instead
  * `isString(s)`: Use `instance(s, str)` instead
  * `_basestring`: Use `str` instead
  * All Exceptions are now in `PyPDF2.errors`:
    - PageSizeNotDefinedError
    - PdfReadError
    - PdfReadWarning
    - PyPdfError
- `PyPDF2.pdf` (the `pdf` module) no longer exists. The contents were moved with
  the library. You should most likely import directly from `PyPDF2` instead.
  The `RectangleObject` is in `PyPDF2.generic`.
- The `Resources`, `Scripts`, and `Tests` will no longer be part of the distribution
  files on PyPI. This should have little to no impact on most people. The
  `Tests` are renamed to `tests`, the `Resources` are renamed to `resources`.
  Both are still in the git repository. The `Scripts` are now in
  https://github.com/py-pdf/cpdf. `Sample_Code` was moved to the `docs`.

For a full list of deprecated functions, please see the changelog of version
1.28.0.

New Features (ENH):
-  Improve space setting for text extraction (#922)
-  Allow setting the decryption password in PdfReader.__init__ (#920)
-  Add Page.add_transformation (#883)

Bug Fixes (BUG):
-  Fix error adding transformation to page without /Contents (#908)

Robustness (ROB):
-  Cope with invalid length in streams (#861)

Documentation (DOC):
-  Fix style of 1.25 and 1.27 patch notes (#927)
-  Transformation (#907)

Developer Experience (DEV):
-  Create flake8 config file (#916)
-  Use relative imports (#875)

Maintenance (MAINT):
-  Use Python 3.6 language features (#849)
-  Add wrapper function for PendingDeprecationWarnings (#928)
-  Use new PEP8 compliant names (#884)
-  Explicitly represent transformation matrix (#878)
-  Inline PAGE_RANGE_HELP string (#874)
-  Remove unnecessary generics imports (#873)
-  Remove star imports (#865)
-  merger.py ➔ _merger.py (#864)
-  Type annotations for all functions/methods (#854)
-  Add initial type support with mypy (#853)

Testing (TST):
-  Regression test for xmp_metadata converter (#923)
-  Checkout submodule sample-files for benchmark
-  Add text extracting performance benchmark
-  Use new PyPDF2 API in benchmark (#902)
-  Make test suite fail for uncaught warnings (#892)
-  Remove -OO testrun from CI (#901)
-  Improve tests for convert_to_int (#899)

Full Changelog: 1.28.4...2.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants